fix(wallet): remove Leap wallet integration#3064
Open
baktun14 wants to merge 6 commits into
Open
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR removes Leap wallet integration across deploy-web and provider-console, refactors GetStartedStepper to accept injected dependencies, deletes Leap-specific LiquidityModal, updates tests, and removes Leap-related dependency/ignore entries. ChangesLeap Wallet Integration Removal and GetStartedStepper refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3064 +/- ##
==========================================
+ Coverage 64.20% 64.57% +0.36%
==========================================
Files 1099 1098 -1
Lines 26868 26792 -76
Branches 6534 6518 -16
==========================================
+ Hits 17251 17300 +49
+ Misses 8417 8307 -110
+ Partials 1200 1185 -15
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@doc/e2e-manual-qa-checklist.md`:
- Line 165: Update the checklist item that currently reads "Wallet extension
modal opens (Keplr/Cosmostation)" to include MetaMask so it reflects all
supported extensions; locate the checklist line containing "Wallet extension
modal opens (Keplr/Cosmostation)" in doc/e2e-manual-qa-checklist.md and change
it to something like "Wallet extension modal opens
(Keplr/Cosmostation/MetaMask)" or similar to explicitly mention MetaMask.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 39688809-1818-4399-9d03-05f80ef6be5b
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (20)
.gitignore.npmrcapps/deploy-web/package.jsonapps/deploy-web/src/components/get-started/GetStartedStepper.tsxapps/deploy-web/src/components/liquidity-modal/index.tsxapps/deploy-web/src/context/CustomChainProvider/CustomChainProvider.tsxapps/deploy-web/src/pages/get-started/index.tsxapps/deploy-web/src/services/analytics/analytics.service.tsapps/deploy-web/src/styles/index.cssapps/deploy-web/src/types/global.tsapps/deploy-web/tests/ui/fixture/context-with-extension.tsapps/deploy-web/tests/ui/fixture/wallet-setup.tsapps/deploy-web/tests/ui/fixture/web-wallet/initKeplrWebWalletMock.tsapps/deploy-web/tests/ui/fixture/web-wallet/injectWebWallet.tsapps/provider-console/package.jsonapps/provider-console/src/context/CustomChainProvider/CustomChainProvider.tsxapps/provider-console/src/pages/get-started/index.tsxapps/provider-console/src/styles/index.cssdoc/e2e-manual-qa-checklist.mdpackages/dev-config/.eslintrc.base.js
💤 Files with no reviewable changes (11)
- .gitignore
- apps/provider-console/package.json
- .npmrc
- apps/deploy-web/package.json
- apps/deploy-web/src/styles/index.css
- apps/deploy-web/src/pages/get-started/index.tsx
- apps/provider-console/src/styles/index.css
- apps/deploy-web/src/types/global.ts
- apps/deploy-web/src/services/analytics/analytics.service.ts
- apps/provider-console/src/pages/get-started/index.tsx
- apps/deploy-web/src/components/liquidity-modal/index.tsx
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/deploy-web/src/components/get-started/GetStartedStepper.spec.tsx`:
- Around line 57-63: The balance mock is only created when input.balanceUAKT
exists, which skips creating a balance object if only balanceUUSDC or
balanceUACT are provided; update the gating in the GetStartedStepper.spec.tsx
test to create the balance object when any of input.balanceUAKT,
input.balanceUUSDC, or input.balanceUACT is defined (e.g., check
input?.balanceUAKT !== undefined || input?.balanceUUSDC !== undefined ||
input?.balanceUACT !== undefined) and still fill the properties using the
existing fallback logic (balanceUUSDC: input?.balanceUUSDC ?? 0, balanceUACT:
input?.balanceUACT ?? 0).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 73bfd44b-e2ee-4e38-b51d-dfb05d35cc99
📒 Files selected for processing (3)
apps/deploy-web/src/components/get-started/GetStartedStepper.spec.tsxapps/deploy-web/src/components/get-started/GetStartedStepper.tsxdoc/e2e-manual-qa-checklist.md
🚧 Files skipped from review as they are similar to previous changes (2)
- doc/e2e-manual-qa-checklist.md
- apps/deploy-web/src/components/get-started/GetStartedStepper.tsx
Contributor
|
should we wait till May 28, 2026? |
Contributor
Author
Sure we can, I don't think it matters. |
ygrishajev
reviewed
Apr 16, 2026
Leap is sunsetting their wallet extension. Remove all Leap-related code including wallet connections, @leapwallet/elements liquidity modal, analytics events, CSS styles, test fixtures, and package dependencies from both deploy-web and provider-console apps. Fixes CON-182
Add unit tests for the GetStartedStepper component covering the balance display logic for both custodial and managed wallets. Introduce the DEPENDENCIES pattern to enable DI-based testing.
Address CodeRabbit review: include MetaMask in the QA checklist since it's still a supported wallet option in deploy-web.
Address CodeRabbit review: balance mock now activates when any of balanceUAKT, balanceUUSDC, or balanceUACT is provided, not just balanceUAKT.
baktun14
force-pushed
the
fix/wallet-remove-leap-wallet
branch
from
c4e6b7e to
91bf950
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
USDC is no longer a Console denom — ACT replaced it as the primary crypto. The Get Started stepper still showed the USDC balance line for custodial wallets; switch it to ACT and update the spec accordingly.
After deleting liquidity-modal, nothing imports apps/deploy-web/src/types/global.ts, so knip flagged it (and its only devDep, @keplr-wallet/types) as unused. The only consumer of the Window augmentation was window.dataLayer in analytics.service.ts — inline a minimal declare global there and remove the dead file + devDep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes CON-182 CON-253
Leap is sunsetting their wallet extension. This PR removes all Leap wallet integration from the codebase.
What
@cosmos-kit/leapand@cosmos-kit/leap-extensiondependencies from deploy-web and provider-console@leapwallet/elementsliquidity modal (swap/bridge/fiat on-ramp) and its CSSCustomChainProviderLeapElementsglobal type declarationleap_get_more_tokens,leap_tx_complete)@leapwallet/elementsscript/stylesheet tags from get-started pagesinitLeapWebWalletMock→initKeplrWebWalletMock)connectWalletViaLeap→connectWalletViaKeplrin test fixtures.npmrc(removed@leapwalletregistry),.gitignore, and ESLint configSummary by CodeRabbit
Wallet Support
Features Removed
Analytics
Styling
Tests
Docs
Chores